Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose createChannelsNode and ChannelsNode type #1755

Open
osnoser1 opened this issue Aug 17, 2024 · 2 comments
Open

Expose createChannelsNode and ChannelsNode type #1755

osnoser1 opened this issue Aug 17, 2024 · 2 comments
Assignees

Comments

@osnoser1
Copy link

Is your feature request related to a problem? Please describe.
Hi all! 😄 I'm working on a visual editing + preview-kit implementation for live real-time for Angular. It is almost done, but I have a concern; I'm using an internal package of the visual-editing repo, the createChannelsNode function of the @repo/channels , so I copied the content. Still, this is not a good approach.

Describe the solution you'd like
Expose createChannelsNode function and the ChannelsNode type or publish to npm the channels package.
The idea is to open the visual editing implementation outside of the react ecosystem.

@rdunk rdunk self-assigned this Aug 19, 2024
@rdunk
Copy link
Member

rdunk commented Aug 23, 2024

Hello! We are currently re-working the channels package to move away from having just an internal repo (i.e. we will likely publish on npm) so I would avoid replicating that logic directly for now if you can.

@osnoser1
Copy link
Author

Hello! We are currently re-working the channels package to move away from having just an internal repo (i.e. we will likely publish on npm) so I would avoid replicating that logic directly for now if you can.

Hi, I'm glad to know this 😄

Well, right now I am testing the angular implementation of visual-editing, I was thinking of releasing a new version with this new feature in the library, and then I can wait for your changes and make the internal refactor, in theory, this shouldn't be a breaking change.

I'll double-check here before making the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants