New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new openseadragon viewer instance for every <OSD /> #169

Open

wykhuh opened this issue Jan 19, 2024 · 0 comments

Contributor

wykhuh commented Jan 19, 2024 •

edited

Loading

In OSD component, a new openseadragron viewer instance is created when that component is created.

clover-iiif/src/components/Viewer/ImageViewer/OSD.tsx

Line 61 in 4080e1f

useEffect(() => {

Is a new viewer instance needed every time OSD loads? Or is it better to have just one instance of openseadragron viewer that is passed a new image url?
is the openseadragon viewer destroyed when the component is dismounted? Or should clover manually destroy the viewer using openseadragon destroy viewer.destroy(); viewer = null?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment