Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should #create! raise an ArgumentError if the instance already has an id? #38

Open
cjcolvar opened this issue Oct 1, 2018 · 0 comments

Comments

@cjcolvar
Copy link
Member

cjcolvar commented Oct 1, 2018

What should happen if #create! is called on an encode instance that already has an id? Should it raise an ArgumentError or should it submit that to the adapter in an attempt to assign that id in the external encoding service? Personally, I would expect that the external service would always assign an id and that an encode instance with an id should raise an exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant