Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FilenameSanitizer] Some S3 uris are not properly sanitized #135

Open
masaball opened this issue Jul 25, 2024 · 0 comments
Open

[FilenameSanitizer] Some S3 uris are not properly sanitized #135

masaball opened this issue Jul 25, 2024 · 0 comments

Comments

@masaball
Copy link
Contributor

masaball commented Jul 25, 2024 •
edited
Loading

The S3 case for sanitizing uris currently uses Addressable::URI's normalized_site method in a gsub. This method lower cases the site name, so S3 uris with a bucket containing capital letters return the whole "s3://bucket/object_path" uri instead of just "object_path".

Replacing normalized_site with site should fix this bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@masaball