Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing modpack from FTB fails on KeyError: 'url' #29

Open
Zajozor opened this issue Dec 10, 2022 · 2 comments
Open

Installing modpack from FTB fails on KeyError: 'url' #29

Zajozor opened this issue Dec 10, 2022 · 2 comments

Comments

@Zajozor
Copy link
Contributor

Zajozor commented Dec 10, 2022

Trying to install https://feed-the-beast.com/modpacks/96-ftb-plexiglass-mountain

(base) zajo@zor-awakened ~ % picomc mod pack ftb install 96
/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/requests/__init__.py:89: RequestsDependencyWarning: urllib3 (1.26.12) or chardet (3.0.4) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
INFO Installing FTB Plexiglass Mountain 1.2.2 as FTB_Plexiglass_Mountain-1.2.2
INFO Fetching Forge metadata
INFO Resolving version
INFO Installing Forge 1.18.2-40.1.84 as 1.18.2-forge-40.1.84
WARNING As the Forge project is kept alive mostly thanks to ads on their downloads
WARNING site, please consider supporting them at https://www.patreon.com/LexManos/
WARNING or by visiting their website and looking at some ads.
INFO Downloading installer
100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:01<00:00,  1.78s/it]
INFO Installing with PicoForgeWrapper
INFO Done installing Forge
WARNING Skipping unsupported target java
Traceback (most recent call last):
  File "/opt/homebrew/Caskroom/miniconda/base/bin/picomc", line 8, in <module>
    sys.exit(main())
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/picomc/__init__.py", line 18, in main
    picomc_cli()
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  [Previous line repeated 1 more time]
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/decorators.py", line 84, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/picomc/cli/utils.py", line 16, in wrapper
    fn(x, *a, **kwa)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/decorators.py", line 84, in new_func
    return ctx.invoke(f, obj, *args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/picomc/mod/ftb.py", line 155, in install_cli
    install(pack_id, version, launcher, im, name, use_beta=beta)
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.8/site-packages/picomc/mod/ftb.py", line 122, in install
    dq.add(f["url"], filepath, f["size"])
KeyError: 'url'

MacOS, M1

click                   8.1.3
picomc                  0.4.5

I suppose the urllib warning at the top isn't critical but also a bit annoying as it's present with every picomc command.
Let me know what else I can provide :) !

@sammko
Copy link
Owner

sammko commented Dec 10, 2022

The urllib warning is probably due to miniconda shipping weird versions of packages. I'd recommend using a vanilla python distribution (brew install python3), potentially even with something like pipx.
I'll have a look at the API issue soon

@sammko
Copy link
Owner

sammko commented Dec 10, 2022

So basically FTB stopped providing download URLs for some files and instead provides curseforge project and file IDs. The curseforge API has been replaced in the meantime as well, so that needs to be fixed first. At least it seems to have documentation this time. https://docs.curseforge.com/#getting-started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants