-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extrafile_refs are ignored when specified in a Saltfile #18353
Labels
Bug
broken, incorrect, or confusing behavior
Core
relates to code central or existential to Salt
fixed-pls-verify
fix is linked, bug author to confirm fix
Salt-SSH
severity-low
4th level, cosemtic problems, work around exists
Milestone
Comments
jfindlay
added
Bug
broken, incorrect, or confusing behavior
severity-low
4th level, cosemtic problems, work around exists
Salt-SSH
labels
Nov 21, 2014
Thanks for reporting this. I'm going to look into it and try to reproduce the problem. |
I am on it |
Found a problem in saltfile loading.... |
thatch45
added a commit
to thatch45/salt
that referenced
this issue
Nov 21, 2014
Ok, that PR does it |
Thanks! Will be able to confirm with a fix to #17313, which is currently breaking my Ubuntu to RHEL provisioning. |
Confirmed that this works for me (in the saltfile). |
Confirmed also now. Thanks, closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
broken, incorrect, or confusing behavior
Core
relates to code central or existential to Salt
fixed-pls-verify
fix is linked, bug author to confirm fix
Salt-SSH
severity-low
4th level, cosemtic problems, work around exists
As per #9878 and #16733,
extra_filerefs
should now be able to be defined in a Saltfile, however my tests with the latest2014.7
show these options get ignored if present.My example Saltfile:
I believe the
SaltfileMixIn
parser is ignoring these options because they're not (explicitly) part of the option list forsalt-ssh
.In the
SaltfileMixIn
parser (https://github.com/saltstack/salt/blob/2014.7/salt/utils/parsers.py#L326), thecli_config
variable has a hold of theSaltfile
contents, includingextra_filerefs
, but the iteration overself.options_list
(andself.option_groups
) only steps through "known" options.extra_filerefs
is thus never mixed into options.In addition, even if I force the option to be copied (with a hack like:
), the options aren't present upon reaching the state wrapper code at https://github.com/saltstack/salt/blob/2014.7/salt/client/ssh/wrapper/state.py#L85. I'm not sure where they're supposed to end up, but both
__opts__
andkwargs
have no value forextra_filerefs
.I'm using the
2014.7
branch.The text was updated successfully, but these errors were encountered: