Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safe deployment functionality to Safe class #446

Closed
dasanra opened this issue May 24, 2023 · 0 comments · Fixed by #980
Closed

Add Safe deployment functionality to Safe class #446

dasanra opened this issue May 24, 2023 · 0 comments · Fixed by #980
Assignees

Comments

@dasanra
Copy link
Collaborator

dasanra commented May 24, 2023

Context / issue

Now that it's possible to init the Safe class only using the intended Safe configuration it will also make sense to have in this class the deployment function. Currently it's required to manually create the deployment transaction and also craft the multisend when it's intended to deploy and execute transactions at the same time

Proposed solution

  • Move the deploy function from SafeFactory to the Safe class.
  • Create a function to deployAndSend transactions.
  • Return a new instance of the Safe pointing to the new deployed Safe instead config based only.
  • Prevent to call the deployment function if the Safe is already deployed.

Alternatives

  • Check for Safe deployment in the normal send transaction removing the need of calling explicitly to a deployment transaction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment