resolve comments in PR wso2-extensions#210

sachiniWettasinghe · Oct 28, 2019 · 1149d97 · 1149d97
1 parent 3bbc008
commit 1149d97
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/...g.wso2.carbon.identity.sso.saml.stub/src/main/resources/IdentitySAMLSSOConfigService.wsdl b/...g.wso2.carbon.identity.sso.saml.stub/src/main/resources/IdentitySAMLSSOConfigService.wsdl
@@ -851,4 +851,4 @@
             <http:address location="https://localhost:9443/services/IdentitySAMLSSOConfigService.IdentitySAMLSSOConfigServiceHttpsEndpoint/"/>
         </wsdl:port>
     </wsdl:service>
-</wsdl:definitions>
+</wsdl:definitions>
diff --git a/...dentity.sso.saml.ui/src/main/java/org/wso2/carbon/identity/sso/saml/ui/SAMLSSOUIUtil.java b/...dentity.sso.saml.ui/src/main/java/org/wso2/carbon/identity/sso/saml/ui/SAMLSSOUIUtil.java
@@ -133,6 +133,7 @@ public static boolean isSingleLogoutEnabled(boolean isSpEdit, SAMLSSOServiceProv
 
     /**
      * Check front-Channel logout enable and if not enable return false.
+     *
      * @param isSpEdit Operation on service provider, create or edit.
      * @param provider SAML2 service provider configuration.
      * @return boolean true if front channel logout enabled.

diff --git a/...so.saml/src/main/java/org/wso2/carbon/identity/sso/saml/admin/FileBasedConfigManager.java b/...so.saml/src/main/java/org/wso2/carbon/identity/sso/saml/admin/FileBasedConfigManager.java
@@ -162,7 +162,7 @@ private SAMLSSOServiceProviderDO[] readServiceProvidersFromFile() {
             if ((getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig.FRONT_CHANNEL_LOGOUT)) != null) {
                 spDO.setDoFrontChannelLogout(Boolean.valueOf(getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig
                         .FRONT_CHANNEL_LOGOUT)));
-                if(spDO.isDoFrontChannelLogout()) {
+                if (spDO.isDoFrontChannelLogout()) {
                     if (getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig.FRONT_CHANNEL_LOGOUT_BINDING) != null) {
                         spDO.setFrontChannelLogoutBinding(getTextValue(elem, SAMLSSOConstants.FileBasedSPConfig
                                 .FRONT_CHANNEL_LOGOUT_BINDING));