Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPMS compatibility broken by net.imglib2.realtransform outside of original package #53

Open
skalarproduktraum opened this issue Feb 23, 2024 · 3 comments

Comments

@skalarproduktraum
Copy link
Contributor

Hey @bogovicj and @axtimwalde,

while trying to get scenery ready to work correctly with the JPMS, the compiler bailed on me, complaining that n5-imglib2 brings along classes that violate package constraints, as some classes actually belong to the net.imglib2.realtransform package.

Unfortunately, the only way to actually fix this is to move them to the package they actually belong to, so the imglib2 package. Would you be open to that? I'd be happy to create PRs for those repositories to make the corresponding changes 👍

@axtimwalde
Copy link
Contributor

axtimwalde commented Feb 23, 2024

I don't understand. ImgLib2 violates package constraints everywhere. How is this different?

@skalarproduktraum
Copy link
Contributor Author

I don't know how it is different, I'm only complaining to the maintainers of the packages where the compiler has complained to me 😅 If this is similar in other places, that'll become an issue too at some point of course.

Anyway - how would you like to handle this for this particular package, @axtimwalde? This affects only the classes in https://github.com/saalfeldlab/n5-imglib2/tree/master/src/main/java/net/imglib2/realtransform and it looks to me as if they could either easily be moved to imglib2, or to somewhere else in this package.

@skalarproduktraum
Copy link
Contributor Author

Poke @bogovicj @axtimwalde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants