Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N5DatasetDiscoverer sometime throws errors if re-used. #40

Open
cmhulbert opened this issue Jun 16, 2022 · 0 comments
Open

N5DatasetDiscoverer sometime throws errors if re-used. #40

cmhulbert opened this issue Jun 16, 2022 · 0 comments

Comments

@cmhulbert
Copy link
Contributor

After creating an N5DatasetDiscoverer you can call discoverAndParseRecursive(base) where base is the base path inside the N5 container you want to start dataset discovery at. Typically, "/" or ""` are common.

Seemingly, it is not safe to call discvoerAndParseRecursive(base) multiple times on the same N5DatasetDiscoverer object. It is not a consistent failure, but sometimes an error occurs, which seems to originate in N5 deepList (specified in to saalfeldlab/n5#82). It doesn't seem to be an issue withdeepList but possibly some state that is incorrectly being retained from prior runs of discoverAndParseRecursive(base). For now, the solution is to create a new instance of N5DatasetDiscoverer when you want to discover, but it may be worth while investigating to see why the discoverer seems to (sometimes) not be safe to use this way.

The issues that brought this to the fore was an intermittent test failure resolved here: c6d0387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant