New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: refactor all hardcoded microarchitectures #198

Closed

ryukzak opened this issue Jan 22, 2022 · 1 comment

Assignees

Labels

Owner

ryukzak commented Jan 22, 2022

Currently we can found in source code:

defMicroarch (

nitta/app/Main.hs

Line 252 in 2646b61

defMicroarch ioSync = defineNetwork "net1" ioSync $ do

)
basic (

nitta/test/NITTA/Model/Tests/Microarchitecture.hs

Line 72 in 2646b61

basic _proxy = defineNetwork "net1" ASync $ do

)
maBroken (same file)
withSlaveSPI (same file)
withMasterSPI (same file)
marchSPI (same file)
marchSPIDropData (same file)
microarch (same file)

All of them implement different microarchitectures with duplicates, bad naming and parameters. We need to refactor it. We need:

oblivious default network in expected module
understandable and compact API for microarchitectures for test. Maybe it should be based on the default network.

ryukzak added enhancement hs labels

ryukzak assigned BasicEC

Owner Author

ryukzak commented Jan 21, 2024

Rethink in: #263

ryukzak closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment