Added support for reading comment segment. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Tiff *tiff.Tiff | ||
| main map[FieldName]*tiff.Tag | ||
| Raw []byte | ||
| Comment string |
There was a problem hiding this comment.
How about a doc-string here describing what Comment is? (I should also probably add doc comments for the rest of those fields too eh?
|
Do you have a sample image or data that could be used for a test? |
Also added a sample image.
|
Added a sample image. |
|
@porridge It seems the author is not very active in this project anymore, many forks have been created. I would like to make this stable and I create goexif2 which integrates your patch: |
|
Thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.