Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MODULE_INIT_COMPRESSED_FILE definition #3782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add MODULE_INIT_COMPRESSED_FILE definition #3782

wants to merge 1 commit into from

Conversation

sinkingpoint
Copy link

@sinkingpoint sinkingpoint commented Jul 22, 2024 •
edited by tgross35
Loading

This adds in the definition for MODULE_INIT_COMPRESSED_FILE so that we can use it in the init_module class of functions to load compressed modules

Fixes #3781

@rustbot
Copy link
Collaborator

rustbot commented Jul 22, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

This was referenced Jul 22, 2024
Closed
Open
@sinkingpoint sinkingpoint force-pushed the sinkingpoint/MODULE_INIT_COMPRESSED_FILE branch from 3f870fa to a9c80e2 Compare July 25, 2024 07:16
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 12, 2024
tgross35
tgross35 approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source link: https://github.com/torvalds/linux/blob/d74da846046aeec9333e802f5918bd3261fb5509/include/uapi/linux/module.h#L8

Thanks!

@tgross35 tgross35 force-pushed the sinkingpoint/MODULE_INIT_COMPRESSED_FILE branch from a9c80e2 to 0663010 Compare August 12, 2024 22:28
@tgross35 tgross35 disabled auto-merge August 12, 2024 23:59
@tgross35
Copy link
Contributor

It looks like there may be some platforms where this isn't available. Could you please take a look at the failures on the latest CI?

@rustbot author

@nathaniel-bennett
Copy link
Contributor

It looks like MOD_INIT_COMPRESSED_FILE was added in Linux 5.17. My guess is that the arm test is failing because it's the first test that runs on a version of Linux older than that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC left review comments

@tgross35 tgross35 tgross35 approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MODULE_INIT_COMPRESSED_FILE is missing for linux
6 participants
@sinkingpoint @rustbot @tgross35 @nathaniel-bennett @SteveLauC @JohnTitor