Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Erase Youtube category #2474

Closed
4 tasks done
GabrielBittar opened this issue Aug 19, 2024 · 15 comments · Fixed by #2489
Closed
4 tasks done

[Refactor] Erase Youtube category #2474

GabrielBittar opened this issue Aug 19, 2024 · 15 comments · Fixed by #2489
Assignees
@GabrielBittar
Labels
goal: refactor Refactoring the codebase multiple issues priority: medium Modifying an existing feature

Comments

@GabrielBittar
Copy link
Contributor

GabrielBittar commented Aug 19, 2024 •
edited
Loading

File Name

/database/youtube

Reason for Refactoring the Code

Changes proposed

Maybe we can think about dissolving Youtube Category, moving each of its links to the categories that fit each subject of each link that is in there.

Reason

Users will most probably search content based on their interest subjects, like "design" or "frontend"... And Ytb is not a subject, it is one of the platforms from which we are taking content to insert inside those subjects.

Example

See Languages > C Programming > CodeWithHarry. This link seems to be in the right place, though it doesn't, at the same time. It is a ytb link, so it could be inside Youtube > WebDevelopment as well and it would not be wrong. There are plenty of other cases that could illustrate this problem. It seems to me youtube channels should be all just like CodeWithHarry, in its repective section, and none inside a Youtube category.

I'm interested in working on it, if this change seems plausible.

Checklist

  • I have checked the existing issues.
  • I have read the Contributing Guidelines.
  • The changes don't break the code and don't introduce new functionality.
  • I am willing to work on this issue (optional).
@GabrielBittar GabrielBittar added goal: refactor Refactoring the codebase priority: medium Modifying an existing feature labels Aug 19, 2024
@github-actions GitHub Actions
Copy link

#2473, #2416 is already opened by you
As per contributing guidelines, you can only work on 1 issue at a time.

@github-actions GitHub Actions
Copy link

Hello GabrielBittar!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@Jay-Karia
Copy link
Contributor

I am up for this change

@rupali-codes
Copy link
Owner

@GabrielBittar i think its gonna be a good practice. What about the links who don't have any category? are we going create new category and subcategory?

@GabrielBittar
Copy link
Contributor Author

@GabrielBittar i think its gonna be a good practice. What about the links who don't have any category? are we going create new category and subcategory?

Yes, this seems to be the best approach, creating the new cats/subs in those cases.
Since the issue looks alright, I intend to start working on this as soon as assigned.

@Anmol-Baranwal
Copy link
Collaborator

@rupali-codes
Please assign him if it's okay. This would be useful imo.

@rupali-codes
Copy link
Owner

@GabrielBittar you're assigned.

@GabrielBittar
Copy link
Contributor Author

@GabrielBittar you're assigned.

Ok! Thanks, I'll start working on it.

@GabrielBittar
Copy link
Contributor Author

GabrielBittar commented Sep 2, 2024 •
edited
Loading

During work, found the seemingly unused DSA folder with DSAYouTube.json. Also found Resources > dsa.json. Total of 3 links. I took the liberty to send these links to data_structures > dsa_tutorials and data_structures > dsa_articles, since there is ady this category for them. I'm communicating since this is not part of the discussed issue, so if you guys think this should not be done, please alert me so I don't send these changes.

@rupali-codes
Copy link
Owner

During work, found the seemingly unused DSA folder with DSAYouTube.json. Also found Resources > dsa.json. Total of 3 links. I took the liberty to send these links to data_structures > dsa_tutorials and data_structures > dsa_articles, since there is ady this category for them. I'm communicating since this is not part of the discussed issue, so if you guys think this should not be done, please alert me so I don't send these changes.

Put them together in the same category but create different subcategory as mentioned :)

@vp007-dev
Copy link

Are you done @GabrielBittar ?

@vp007-dev
Copy link

I am for this task tho.

@GabrielBittar
Copy link
Contributor Author

Are you done @GabrielBittar ?

No, I'm working on it.

@vp007-dev
Copy link

vp007-dev commented Sep 6, 2024 via email

@GabrielBittar GabrielBittar mentioned this issue Sep 8, 2024
Merged
@github-actions GitHub Actions
Copy link

Thank you for contributing to LinksHub! Please take a moment to rate this repo's DX on EddieHub's RepoRater and give it a star ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GabrielBittar GabrielBittar

Labels
goal: refactor Refactoring the codebase multiple issues priority: medium Modifying an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: erase Youtube category GabrielBittar/LinksHub-gabfork
5 participants
@GabrielBittar @vp007-dev @Anmol-Baranwal @rupali-codes @Jay-Karia