Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new design of nav menu in mobile devices #2196

Closed
Anmol-Baranwal opened this issue Nov 26, 2023 · 5 comments · Fixed by #2198
Closed

feat: add new design of nav menu in mobile devices #2196

Anmol-Baranwal opened this issue Nov 26, 2023 · 5 comments · Fixed by #2198
Assignees
Labels
goal: new-design Design related issues 🔒 locked priority: high Making completely new feature 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

You can view the figma file here.

image

The design should be responsive.


ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • You can get icons from here
  • You need to implement the active state and navigating to correct route based on selected nav icon.

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.


⚠️ Make sure to push all the changes into dev branch

@Anmol-Baranwal Anmol-Baranwal added up for grabs this issue open for the taking goal: new-design Design related issues priority: high Making completely new feature labels Nov 26, 2023
Copy link

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

Copy link

Hello Anmol-Baranwal!
Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Please only work on an issue if you're assigned; otherwise, the PR will be automatically closed.
Our review team will carefully assess the issue and reach out to you soon! 😇
We appreciate your patience!

@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2023
Repository owner unlocked this conversation Nov 26, 2023
@Anmol-Baranwal
Copy link
Collaborator Author

@rupali-codes
I'm creating this because the header design PR is merged, and since there's no sidebar option, I assume we're going with bottom navigation.

@MAXASSASSINS
Copy link
Contributor

Hi @Anmol-Baranwal could you please assign this issue to me.

@Anmol-Baranwal
Copy link
Collaborator Author

@MAXASSASSINS
I have assigned you the issue. Please proceed with it, and don't hesitate to tag any of the maintainers if you require any assistance.

@Anmol-Baranwal Anmol-Baranwal added 🚀 ready and removed up for grabs this issue open for the taking labels Nov 26, 2023
@Anmol-Baranwal Anmol-Baranwal linked a pull request Dec 1, 2023 that will close this issue
@CBID2 CBID2 closed this as completed Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-design Design related issues 🔒 locked priority: high Making completely new feature 🚀 ready
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants