Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new design for saved resources #2174

Closed
Anmol-Baranwal opened this issue Nov 1, 2023 · 10 comments · Fixed by #2211
Closed

feat: add new design for saved resources #2174

Anmol-Baranwal opened this issue Nov 1, 2023 · 10 comments · Fixed by #2211
Assignees
@Vidip-Ghosh
Labels
development Still being developed goal: new-design Design related issues 🚀 ready

Comments

@Anmol-Baranwal
Copy link
Collaborator

Anmol-Baranwal commented Nov 1, 2023 •
edited by rupali-codes
Loading

You can view the figma file here.

image

The design should be responsive.

ℹ️ We recommend updating the styling of existing components, otherwise you can add extra components if there is a need.

  • You have to design the resources page as shown above.
  • You also have to design the page in case no resources have been saved.

image

  • You need to implement the functionality of remove all

image

  • You need to redesign the card component

image

Any changes to the above design are welcome. Please feel free to share your thoughts, and we will discuss them thoroughly.

⚠️ Make sure to push all the changes into dev branch
@Anmol-Baranwal Anmol-Baranwal mentioned this issue Nov 1, 2023
Closed
11 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2023

To reduce notifications, issues are locked. Your issue will be unlocked when we add the label, 🚀 ready.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
@Anmol-Baranwal Anmol-Baranwal changed the title Saved resources page feat: add new design for saved resources Nov 1, 2023
@rupali-codes rupali-codes added goal: new-design Design related issues development Still being developed up for grabs this issue open for the taking 🚀 ready and removed 🔒 locked labels Nov 2, 2023
Repository owner unlocked this conversation Nov 2, 2023
@Vidip-Ghosh
Copy link
Contributor

I would like to work on this.

@rupali-codes
Copy link
Owner

I would like to work on this.

Sure, assigning to you!

@rupali-codes rupali-codes removed the up for grabs this issue open for the taking label Nov 4, 2023
@rupali-codes
Copy link
Owner

@Vidip-Ghosh any updates? Are you still willing to work on this?

@Vidip-Ghosh
Copy link
Contributor

@Vidip-Ghosh any updates? Are you still willing to work on this?

@rupali-codes actually I have been assigned the firebase auth issue so even working on that + I was busy in my academics this week so I wasn't able to start this issue. But I am willing to work on this issue.

@Anmol-Baranwal
Copy link
Collaborator Author

But bookmark was not going to be there, right? Or will it be.

@Vidip-Ghosh
Copy link
Contributor

Vidip-Ghosh commented Nov 22, 2023 •
edited
Loading

But bookmark was not going to be there, right? Or will it be.

Even confused of this. I think we should save the resources on the basis of resource upvoted and display in saved resources. Will that be feasible?

@rupali-codes
Copy link
Owner

But bookmark was not going to be there, right? Or will it be.

Even confused of this. I think we should save the resources on the basis of resource upvoted and display in saved resources. Will that be feasible?

yep, sounds good though

This was referenced Dec 19, 2023
Closed
Closed
Merged
@CBID2 CBID2 linked a pull request Dec 22, 2023 that will close this issue
feat: saved resources page #2211
Merged
@CBID2 CBID2 reopened this Dec 28, 2023
@abed-obaah
Copy link

Has anyone worked on it? I would like to!

@Anmol-Baranwal
Copy link
Collaborator Author

Has anyone worked on it? I would like to!

This is assigned to vidip. Please create new issue or comment with issues having label: up for grabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vidip-Ghosh Vidip-Ghosh

Labels
development Still being developed goal: new-design Design related issues 🚀 ready
Projects
None yet
Milestone
No milestone
5 participants
@Anmol-Baranwal @rupali-codes @Vidip-Ghosh @abed-obaah @CBID2