Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not All Pages Are Full Responsive #1

Open
seanmarcia opened this issue Nov 23, 2020 · 9 comments
Open

Not All Pages Are Full Responsive #1

seanmarcia opened this issue Nov 23, 2020 · 9 comments
Labels
Status: Blocked 🚫 Something else is blocking this Type: UX/UI 💄 Frontend changes

Comments

@seanmarcia
Copy link
Member

We have a few pages that aren't fully responsive. We need to fix that for folks browsing on mobile devices.

Here are a few:

@giacoelho giacoelho added the Help Wanted 🆘 Extra attention is needed label Dec 2, 2020
@meg-gutshall meg-gutshall self-assigned this Feb 24, 2021
@meg-gutshall
Copy link
Member

Hi @onerinas! I'm excited to have your help in making the site fully responsive!

@onerinas
Copy link
Contributor

onerinas commented May 3, 2021

I'll start with the about us page.

@onerinas
Copy link
Contributor

@meg-gutshall #7 fixes about us page. Please have a look.

@meg-gutshall
Copy link
Member

@onerinas Since you did so well with the About Us page (#7), would you like to go through the pages and see if there are any other responsiveness issues that need to be fixed? I know the navigation bar looks a little wonky.

@onerinas
Copy link
Contributor

onerinas commented Jun 6, 2021

That was my plan - get one page merged first and then pick up other pages 😎

@onerinas
Copy link
Contributor

@onerinas Since you did so well with the About Us page (#7), would you like to go through the pages and see if there are any other responsiveness issues that need to be fixed? I know the navigation bar looks a little wonky.

@meg-gutshall Didn't work on navigation. Tried to replace the js code we have for mobile nav and use the code from bootstrap's example. That looked like more work so dropped that plan for now.

Please have a look at #8 which adds responsiveness for Home & Donate pages.

@onerinas onerinas removed their assignment Jul 3, 2021
@arielj
Copy link
Contributor

arielj commented Aug 21, 2021

hi! would it make sense to have issues for each screen instead of one for all the responsiveness issues? I'm checking the different screens and some would need specific fixes that will only apply for that screen. Maybe it's easier to keep track?

@meg-gutshall
Copy link
Member

Hi @arielj! Thank you for the suggestion! This site has been in MVP status for about a year and we're slowly working on getting it into v1 state. I anticipate having more time in September to work on doing this.

Were there any pages in particular that you saw needed attention? I welcome you to create new issues for anything you see on our website! I see that you work with Ernesto at Ombu and know the quality of code that comes out of there—I'm a Philly native myself—so I'd welcome any of your contributions, whether via issue creation or pull requests.

@arielj
Copy link
Contributor

arielj commented Aug 24, 2021

@meg-gutshall thanks! I'll create some issues for different things I noticed, some are more general applying to all pages (like the mobile header that looks a bit weird) and some for specific pages

@meg-gutshall meg-gutshall removed their assignment Oct 27, 2021
@meg-gutshall meg-gutshall added the Type: UX/UI 💄 Frontend changes label Oct 27, 2021
@meg-gutshall meg-gutshall added the Status: Blocked 🚫 Something else is blocking this label Jul 20, 2022
@meg-gutshall meg-gutshall removed the Help Wanted 🆘 Extra attention is needed label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Blocked 🚫 Something else is blocking this Type: UX/UI 💄 Frontend changes
Projects
None yet
Development

No branches or pull requests

5 participants