Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Rails/LinkToBlank, because it is outdated #1294

Open
runephilosof-abtion opened this issue Jun 11, 2024 · 3 comments
Open

Disable Rails/LinkToBlank, because it is outdated #1294

runephilosof-abtion opened this issue Jun 11, 2024 · 3 comments

Comments

@runephilosof-abtion
Copy link

This is only a vulnerability in over three years old browsers.

- https://mathiasbynens.github.io/rel-noopener/

From https://mathiasbynens.github.io/rel-noopener/

2021 update: Browsers now implicitly set rel=noopener for any target=_blank link, following a spec change. If the demo on this page no longer seems scary, congratulations — you’re using a modern browser!

So the cop should be disabled.

@Earlopain
Copy link
Contributor

3 years doesn't seem that long ago, an update to the cops documentation pointing this out seems more appropriate.

@runephilosof-abtion
Copy link
Author

runephilosof-abtion commented Jun 24, 2024

I don't think we should be encouraging developers to litter their code with rel=noopener to make it safer for users running three years old browsers. Those users with so old browsers have a ton of remote code execution bugs in their browsers, so whether or not rel=noopener is there, won't make a big difference to them.

@Earlopain
Copy link
Contributor

There no doubt that users with old browser have a plethora of issues and really should update. For me there are still a good chunk that don't do that for one reason or another. I can't tell what the consequences would be for those if this is disabled. If it does anything at all I'd prefer to keep it.

That's just my personal opinion, I don't know when a good point would be to disable this. Maybe now, maybe a year ago already, or just 5 years in the future. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants