Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: issue change notifications for transient transaction elements too #3258

Open
pmatilai opened this issue Aug 28, 2024 · 1 comment
Open
Labels
API API related RFE

Comments

@pmatilai
Copy link
Member

Something that came up in discussion with the dnf team yesterday (@jrohel, @mblaha, @pkratoch):

Rpm issues change notifications for transactions elements as they get added and removed to the transaction to allow API users to keep track of the changes that rpm does behind the scenes (such as replacing an older version with a newer). The change notification is also handy for setting application private pointers to the elements, and at least dnf5 relies on this in their transaction callback. However, no notification is issued for the transient TE_RPMDB elements that are created by rpm for the sole purpose of giving a package context to trigger scriptlets whose owner is not part of the transaction but installed already.

We should issue change notifications for the create + destruction of TE_RPMDB elements too, but using some different event code from the normal elements because these are not being added/removed to the transaction as such, they are just temporary and short-lived elements.

@pmatilai pmatilai added RFE API API related labels Aug 28, 2024
@pmatilai
Copy link
Member Author

A random note of the day: maybe we should actually remember these elements in the transaction, because they do take part in it, just not the usual added/removed manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related RFE
Projects
Status: Todo
Development

No branches or pull requests

1 participant