Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location params to POST streams/:id/ #35

Open
hburgund opened this issue Jan 13, 2018 · 0 comments
Open

add location params to POST streams/:id/ #35

hburgund opened this issue Jan 13, 2018 · 0 comments
Assignees

Comments

@hburgund
Copy link
Member

Per RW API V2, both latitude and longitude need to be sent as POST params in POST streams/:id.

This is of crucial importance for geo-listen-enabled projects as it allows the stream to set the speaker volumes properly as well as determine if the listener is in range for the project.

It is also required even when geo-listen-enabled is false (this is admittedly not intuitive, but it's a thorny issue on the server and since we are pushing towards client-side mixing, is not worth the effort to figure out and fix). Sending the default location of 1/1 will be fine, though the best solution would be to send the project default location taken from the response to GET projects/:id/ - https://roundware.org/api/#get-projects-id. No need to worry about the latter solution unless it is no harder to do than the former.

loafofpiecrust referenced this issue in loafofpiecrust/roundware-ios-framework-v2 Mar 4, 2018
hburgund added a commit to hburgund/roundware-ios-framework-v2 that referenced this issue Mar 4, 2018
hburgund added a commit to hburgund/roundware-ios-framework-v2 that referenced this issue Mar 4, 2018
hburgund added a commit to hburgund/roundware-ios-framework-v2 that referenced this issue Mar 8, 2018
hburgund added a commit to hburgund/roundware-ios-framework-v2 that referenced this issue Mar 8, 2018
hburgund pushed a commit to hburgund/roundware-ios-framework-v2 that referenced this issue Aug 28, 2019
* 🎉 Untested pass at proximity fading

* 🎨 Fix indent

* 🪲 Only mark asset as played after finishing

* ✨ Use deadAir upperBound and rename field

* 🪲 Fix extra time past asset end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants