Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle PATCH streams/ requests in Listen filter screen #30

Open
hburgund opened this issue Oct 18, 2017 · 0 comments
Open

Throttle PATCH streams/ requests in Listen filter screen #30

hburgund opened this issue Oct 18, 2017 · 0 comments

Comments

@hburgund
Copy link
Member

Currently, each time a tag is selected or unselected, a PATCH streams/ request is sent to the server with the new list of tag filters. This leaves open the possibility of a user rapidly tapping items on and off which would potentially cause overloading issues or odd behavior on the server. The client should prevent this behavior.

Two possible fixes are:

  • Put some kind of timer on the sending of the requests to the server so only one can be sent per few seconds.
  • Move the request triggering from the tag selection to the button that returns the user to the Listen screen. In this case, the button returning users to the Listen screen should say something like "Done" or "Apply" to suggest the user's selections are not applied until the button is pressed.

I am fine with either method at this point. If they require equal effort, the latter is probably more sensible overall, but there are arguments for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants