Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tabs component #11

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: tabs component #11

merged 2 commits into from
Sep 13, 2023

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Sep 8, 2023 •
edited
Loading

@lukicenturi lukicenturi requested a review from a team as a code owner September 8, 2023 06:42
@lukicenturi lukicenturi force-pushed the feat-compat/tabs branch 11 times, most recently from 2b7347c to c61f069 Compare September 10, 2023 13:03
tewshi
tewshi reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tewshi tewshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

kelsos
kelsos reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It seems that one of the properties in the classes is undefined

@lukicenturi
Copy link
Contributor Author

image

It seems that one of the properties in the classes is undefined

Updated, apparently it came from VRender

kelsos
kelsos approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@kelsos kelsos merged commit b4fd80c into rotki:main Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tewshi tewshi tewshi left review comments

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukicenturi @kelsos @tewshi