From 9dcff7f7b59e3e820853ab59c362875adbe75035 Mon Sep 17 00:00:00 2001 From: Daniel Stonier Date: Tue, 16 Jul 2019 18:07:51 -0400 Subject: [PATCH] drop the warning and guard, lean on the graceful degradation as recommended in review --- launch/launch/actions/execute_process.py | 7 ------- 1 file changed, 7 deletions(-) diff --git a/launch/launch/actions/execute_process.py b/launch/launch/actions/execute_process.py index a5bf39e4e..3c4473225 100644 --- a/launch/launch/actions/execute_process.py +++ b/launch/launch/actions/execute_process.py @@ -529,13 +529,6 @@ async def __execute_process(self, context: LaunchContext) -> None: )) except KeyError: emulate_tty = self.__emulate_tty - # guard against windows - tty emulation is not yet working - # https://github.com/ros2/launch/issues/268 - if emulate_tty and platform.system() == 'Windows': - self.__logger.warning( - 'tty emulation not yet supported on windows, disabling' - ) - emulate_tty = False try: transport, self._subprocess_protocol = await async_execute_process( lambda **kwargs: self.__ProcessProtocol(