Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in documentation #243

Closed
Tracked by #283
roncapat opened this issue Jan 4, 2024 · 2 comments
Closed
Tracked by #283

Broken link in documentation #243

roncapat opened this issue Jan 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@roncapat
Copy link

roncapat commented Jan 4, 2024

Describe the bug
At https://ros-industrial.github.io/ros2_canopen/manual/rolling/user-guide/how-to-create-a-cia301-system.html
the link in the last section is broken (https://github.com/ros-industrial/ros2_canopen/blob/master/canopen_ros2_control/launch/canopen_system.launch.py).

Side note: it would be better to provide also the example XML <ros2_control> block to the user.

@roncapat roncapat added the bug Something isn't working label Jan 4, 2024
@ipa-vsp ipa-vsp closed this as completed Apr 23, 2024
@roncapat
Copy link
Author

@ipa-vsp I've seen you closed, later reverted patch. Should this Issue be reopened again?

@ipa-vsp ipa-vsp mentioned this issue May 4, 2024
6 tasks
@ipa-vsp
Copy link
Member

ipa-vsp commented May 4, 2024

@roncapat The pull request you submitted is for the 'gh-page' branch, which is automatically created by GitHub and will be overwritten during the next build. As a result, I will include it in issue #283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants