Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arctic_admin missing icons #260

Closed
CR1AT0RS opened this issue Sep 27, 2020 · 2 comments
Closed

Arctic_admin missing icons #260

CR1AT0RS opened this issue Sep 27, 2020 · 2 comments
Labels

Comments

@CR1AT0RS
Copy link
Contributor

CR1AT0RS commented Sep 27, 2020

Bug report:

  • Expected Behavior:
    Arctic_admin icons show up
  • Actual Behavior:
    Arctic_admin icons missing

Original issue: cprodhomme/arctic_admin#39
Fontawesome dependecy required

@CR1AT0RS
Copy link
Contributor Author

pull request: #261

@sjieg
Copy link

sjieg commented Sep 28, 2020

Good stuff @CR1AT0RS I was just looking for this.

For reference while other people finding this ticket:
While I was implementing your solution, I tried to use our pro license:

import "@fortawesome/fontawesome-pro/css/all.css";

But this does not work, because font-family: 'Font Awesome Free 5'; is directly defined in the css. I've reported a suggested feature to support this as well: #262

For now I'll just have to have both pro and free installed in my node_modules.

@santib santib closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants