Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbx_binary: Replace C-binding crate lz4 with a native Rust LZ4 Library #255

Open
jmkd3v opened this issue Mar 18, 2023 · 1 comment
Open
Labels

Comments

@jmkd3v
Copy link

jmkd3v commented Mar 18, 2023

This one library has been a blocker in building rbx_binary for WebAssembly.

@Dekkonot
Copy link
Member

I would love to support this use-case but it does lead us to a weird spot with support for ZSTD suppression. There doesn't exist, as far as I know, a native implementation of ZSTD for Rust. This means that any support we add for it would cause the same problem because of their C-binding. We could lock ZSTD support behind a feature (which is probably a good idea anyway given most people won't need it) but that's only something we need to consider if we switch to using e.g. lz4_flex over lz4.

If we were to switch to using a non-C implementation for LZ4 decoding, what other blockers if any would exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants