Skip to content
This repository has been archived by the owner on Nov 7, 2020. It is now read-only.

Update code style to be more consistent w. js-assessment #31

Open
jamesplease opened this issue May 8, 2015 · 4 comments
Open

Update code style to be more consistent w. js-assessment #31

jamesplease opened this issue May 8, 2015 · 4 comments

Comments

@jamesplease
Copy link
Collaborator

This is a pretty minor point, but there are some stylistic differences between js-assessment and these answers. The one that stood out to me is that in this app there's a space after colons (ref), whereas this doesn't seem to be the style in js-assessment.

Maybe we can do a quick comparison of the code styles and whip up a PR to make them more consistent.

@ashleygwilliams
Copy link
Collaborator

yes i agree- what about throwing in jscs?

@jamesplease
Copy link
Collaborator Author

I 💘 jscs, but at the moment this repo is pretty lightweight, being just the javascript files themselves with nothin' else. It's not a huge decision, but it is a notable change if we were to add jscs. Presumably it could be as simple as adding a package.json manifest and an inline script to run the command, along with the .jscsrc file.

Another option would just be to loosely follow the convention in a manual way. It'd be less precise, but maybe good enough for the purposes of this little library?

I'd prob. be fine going with either, I think.

@ashleygwilliams
Copy link
Collaborator

i think the reason i like jscs would be that it documents itself, and then people who contribute know what needs to happen so we don't have to nitpick their PRs. saves us on maintenance, gives contributors confidence.

@jamesplease
Copy link
Collaborator Author

Fine by me. Let's do it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants