Code Review #2

[harishschandra]

I am glad to see that you have resolved most of the issues that I had bought up previously. There are still a few issues that I found that needs to be rectified.

1. You have improved your GitHub Readme from before. However, it still needs to explain the project
   pipeline and major technologies being used properly.
2. In the file emoji.py, you have used a threshold of 0.8. However, it is not clear as to how or why you
   used this threshold.
3. In the same file emoji.py, you have used the scaling factor to be 1.1. Why have you used this value?
   Also, shouldn’t the scaling factor be dynamic, so that it can be viewed on different screens? I have
   the same issue with the next 2 lines of code as well, where you have arbitrarily assigned 5 to
   minNeighbors without explaining why, and used the size of 30 by 30 for minSize.
4. When I try to run your code using the commandline command python real-time.py haar-
   cascade_frontalface_default.xml, it gives me an error saying: error: (-215) scn == 3 || scn == 4 in
   function ipp_cvtColor. Is it maybe because you need to give a time delay between when you start
   the videocapture and when you call the while loop? Or you can also try this:
   if ret is True:
   img_gray = cv2.cvtColor(frame, cv2.COLOR_BGR2GRAY)
   else:
   continue

Overall, I think your project is very interesting and you have done a very good job in carrying it out. I am looking forward to see your finished project during the poster presentation. Good luck!