Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DigitMap keyword for intuitively inserting digit map (dial plan) #78

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

richard-kung
Copy link

  • Allow to insert digit map anywhere instead of appending it
  • Allow to specify input dial plan filename directly for easily managing mutiple dial plans
  • Change default decoded dialplan.txt to dialplan_output.txt to prevent accidentally overwrite input file

Example files:

  • examples/packetcable_digitmap.txt (line 40)
  • examples/packetcable_digitmap.cfg

- Allow to insert digit map anywhere instead of appending it
- Allow to specify input dial plan filename directly for easily managing mutiple dial plans
- Change default decoded dialplan.txt to dialplan_output.txt to prevent accidentally overwrite input file

Example files:
- examples/packetcable_digitmap.txt (line 40)
- examples/packetcable_digitmap.cfg
@rlaager
Copy link
Owner

rlaager commented Mar 15, 2024

@richard-kung Just so you're aware, I don't use this software any more and know very little about its codebase. So while I gave the project repository a home, my ability to review changes is limited.

I did give this a read through. I don't see anything obviously wrong here at first glance.

@richard-kung
Copy link
Author

@rlaager I will handle Cable modem/eMTA projects for at least one year and will use this tool. If you need some helps, feel free to ask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants