Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear demonstration on how parameters (beta, phi) are used in data generation for each family? #15

Open
linyingyang opened this issue Jun 25, 2024 · 2 comments

Comments

@linyingyang
Copy link
Collaborator

It seems hard to find how the parameters specified / input by users will be used in data generation for a particular family. For example, suppose I have $A$ (binary treatment indicator) ~ $I_1+I_2+I_3+X_1$ where $I_j$ denotes instrumental variables, $X_j$ denotes confounders. The family specified for this fomula is 'Bernoulli', where I want the propensity score / the parameter for the bernoulli distribution to be $expit(\beta_0 + \beta_1I_1 + \beta_2I_2 + \beta_3I_3 + \beta_4I_4)$. I specify $beta = (\beta_0, ... \beta_4)$ for argument pars, but I couldn't find documentation that the propensity score is exactly the form that I was expecting.

@rje42
Copy link
Owner

rje42 commented Jun 25, 2024

This can be checked easily enough by fitting a GLM with the logistic regression. What you've done sounds correct to me. What do you suggest?

@linyingyang
Copy link
Collaborator Author

I checked by fitting a GLM with logistic regression, and it worked just like I expected.

I think the documentation could be clearer. Maybe we could add a section (or simply just a table) that lists all the families and shows example parameter specifications, including where each parameter goes (like which position we should put coefficients or constants). It would make it easier for users to find the right info quickly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants