Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance of IDL analysis passes #74

Open
dhower-qc opened this issue Oct 4, 2024 · 0 comments
Open

Fix performance of IDL analysis passes #74

dhower-qc opened this issue Oct 4, 2024 · 0 comments

Comments

@dhower-qc
Copy link
Collaborator

The IDL analysis passes like possible_exceptions are super slow. This is likely caused by a few things:

  • They execute IDL code through the AST value() classes, and rely on ValueError exceptions to catch when values aren't known. That causes a lot of exceptions. We could get a substantial performance improvement by reporting unknown values a different way (converting to throw/catch would take the least amount of work. converting to explicitly checked return values would be best performance but code change)
  • Value calculations are repeated a lot on AstNodes since the result is rarely cached. Caching would help.
  • I think we could probably find ways to get an earlier out from some passes so there is less work done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant