Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Fix use of use_gateway #1593

Closed
kalzoo opened this issue Jun 9, 2023 · 1 comment · Fixed by #1598
Closed

v4: Fix use of use_gateway #1593

kalzoo opened this issue Jun 9, 2023 · 1 comment · Fixed by #1598
Assignees
Labels

Comments

@kalzoo
Copy link
Contributor

kalzoo commented Jun 9, 2023

Currently, use_gateway is accepted as an argument to both:

but it is not passed between the two in the load() call. A user could get past this by constructing a QcsClient themselves, but this is not ideal.

Two ways to fix this:

  1. Pass the argument to QcsClient::load, or:
  2. Better yet, make the changes as described in Standardize use_gateway as part of configuration qcs-sdk-rust#310 and then remove the use_gateway argument here, which is inconsistent with the other aspects of client configuration.
@MarquessV
Copy link
Contributor

closed via #1598

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants