-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for unblocking RHEL-10 container builds #5889
Conversation
This will unblock container refreshes. This affects also RHEL. Related: https://bugzilla.redhat.com/show_bug.cgi?id=2295428 Related: https://issues.redhat.com/browse/RHEL-46558 Cherry-picked from master branch commit: 56e0269.
/kickstart-tests --waive unit tests covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just not sure if the second commit is intended to be actually a part of this infra PR ?
@@ -169,7 +169,7 @@ def test_get_default_file_system(self): | |||
def test_get_supported_raid_levels(self): | |||
"""Test GetSupportedRaidLevels.""" | |||
assert self.interface.GetSupportedRaidLevels(DEVICE_TYPE_MD) == \ | |||
['linear', 'raid0', 'raid1', 'raid10', 'raid4', 'raid5', 'raid6'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to be there ? I find it strange this is part of an infra PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it's not an infra PR.
It's a PR with some fixes that are needed to re-enable building centos10 and centos9 containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even the 'infra' marked commit - has tests changes.
infra check is naive - checking per-pr - not per-commit validity. |
This will unblock container refreshes.
This affects also RHEL.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=2295428
Related: https://issues.redhat.com/browse/RHEL-46558
Cherry-picked from master branch commit: 56e0269.