Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend eblob summary statistics for defragmentation status #128

Open
shaitan opened this issue Jun 15, 2015 · 2 comments
Open

Extend eblob summary statistics for defragmentation status #128

shaitan opened this issue Jun 15, 2015 · 2 comments

Comments

@shaitan
Copy link
Member

shaitan commented Jun 15, 2015

Current state

Currently, eblob summary has follow statistics:

  • records_removed - total number of removed records in all blobs
  • records_removed_size - total size of all removed records in all blobs
  • want_defrag - sum of want_defrag of all blobs

Problem

There is no statistics that shows the need and potential profit from defragmentation:

  • want_defrag is useless because it mixes want_defrag of all blobs
  • records_removed and records_removed_size are about all removed records from all blobs and don't show how many space will be freed by defragmentation

What is wanted to be changed

Add new statistics or change current statistics if it is possible. These statistics should show:

  • the need for defragmentation: 0 - defragmentation is useless now, 1 - defragmentation will make a profit
  • current profit from defragmentation: how many resources will be freed (disk space, fd etc.)
@agodin
Copy link

agodin commented Jun 15, 2015

like!

@shaitan
Copy link
Member Author

shaitan commented Jun 16, 2015

Update

  • "profit from defragmentation" won't be implemented
  • summary:want_defrag will take one of follow values:
    • 1 - when there is at least one unsorted blob or blob with want_defrag equal to 1 (EBLOB_DEFRAG_NEEDED) or 2 (EBLOB_REMOVE_NEEDED)
    • 0 - in all other cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants