BUG FIX: start bash insteed zsh #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darosior
reviewed
May 17, 2022
There was a problem hiding this comment.
Thank you for the pull request. However overriding the SHELL env var ourselves is not the right approach. The point of having
SHELL = os.getenv("SHELL", "bash")is to let one pass any shell they want to use when invoking the script.
In the case of zsh you may just do (assuming you've bash installed):
SHELL=bash ./aquarium.py --your options ...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #33
Description
Solution 2 as mentioned in issue #33
SHELL is changed to
/usr/bin/bashwhen default shell is zsh.implement
SHELL = os.getenv("SHELL", "/usr/bin/bash")
if SHELL.endswith('/zsh'):
SHELL="/usr/bin/bash"