Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mso-font-width: NaN% #1643

Open
christoph-pflueger opened this issue Aug 29, 2024 · 3 comments
Open

mso-font-width: NaN% #1643

christoph-pflueger opened this issue Aug 29, 2024 · 3 comments

Comments

@christoph-pflueger
Copy link

Describe the Bug

In the function computeFontWidthAndSpaceCount in the Button component, a division by zero results in <!--[if mso]><i style="mso-font-width:NaN%;mso-text-raise:18" hidden></i><![endif]-->.

Which package is affected (leave empty if unsure)

@react-email/button

Link to the code that reproduces this issue

https://github.com/resend/react-email/blob/canary/packages/button/src/__snapshots__/button.spec.tsx.snap

To Reproduce

Not needed, as even the snapshots contain the bug.

Expected Behavior

It should not result in NaN%

What's your node version? (if relevant)

No response

@gabrielmfern
Copy link
Collaborator

Can you check this out with @react-email/[email protected]?

@christoph-pflueger
Copy link
Author

Works as expected, thank you.

@gabrielmfern
Copy link
Collaborator

gabrielmfern commented Sep 20, 2024

Nice to know! Let's just close this one once it is released out of canary

@gabrielmfern gabrielmfern reopened this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants