Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/Proactively remove uv detritus #294

Merged
merged 5 commits into from
Sep 27, 2024
Merged

Conversation

blast-hardcheese
Copy link
Collaborator

Why

uv init creates README.md, hello.py, and .python-version files. These are noisy and don't match the behavior of other python package managers in upm, so let's patch that up.

What changed

  • Added more flags to uv init
  • Test for hello.py before and after uv init. If it gets created through that process, delete it.

Test plan

New agent runs should not have hello.py, uv's README.md, or .python-version files

@blast-hardcheese blast-hardcheese requested a review from a team as a code owner September 27, 2024 17:37
@blast-hardcheese blast-hardcheese requested review from vlinkz and removed request for a team September 27, 2024 17:37
internal/backends/python/python.go Outdated Show resolved Hide resolved
internal/backends/python/python.go Outdated Show resolved Hide resolved
internal/backends/python/python.go Outdated Show resolved Hide resolved
@cbrewster
Copy link
Member

Oh goodness review race condition 🤣

@blast-hardcheese blast-hardcheese enabled auto-merge (squash) September 27, 2024 17:55
@blast-hardcheese blast-hardcheese merged commit dd4c4b9 into main Sep 27, 2024
3 checks passed
@blast-hardcheese blast-hardcheese deleted the dstewart/bug/uv-detritus branch September 27, 2024 18:16
@blast-hardcheese blast-hardcheese added the bug Something isn't working label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants