DX-780: Avoid guessing common words/module names #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
pypi permits packages with extraordinarily common names (utils) as well as misconfigured packages (
gardener-cicd-base
, in this case, pollutessite-packages
withutil.py
,model/
, andci/
, among others)What changed
I crossreferenced top-level packages discovered from pypi packages with
/usr/share/dict/words
then hand-pruned down to what I believe is a sensible list of names that can be common internal module names for projects, as well as excluding names that are popular pypi packages.If there are any incorrect or missing entries, we can tune this over time, this is just trying to prevent
import util
guessing random stuff.Test plan
Before
After