Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCaml support broken #118

Open
cuihtlauac opened this issue Mar 6, 2024 · 0 comments
Open

OCaml support broken #118

cuihtlauac opened this issue Mar 6, 2024 · 0 comments

Comments

@cuihtlauac
Copy link

cuihtlauac commented Mar 6, 2024 •
edited
Loading

Using:

  • ocaml 5.1.1
  • ocaml-compiler-libs v0.12.4
  • ocamlfind 1.9.6

Here is what I do (in a fresh clone, using Ubuntu 23.10):

$ cd languages/ocaml
$ ocaml repl.ml -e "let foo = 1;;"
File "./repl.ml", line 111, characters 23-36:
111 |       use_silently ppf explicit_name
                             ^^^^^^^^^^^^^
Error: This expression has type string but an expression was expected of type
         input = Toploop.input
cuihtlauac pushed a commit to cuihtlauac/prybar that referenced this issue Mar 6, 2024
Support ocaml-compiler-libs v0.12.4
298742d 
As of ocaml-compiler-libs v0.12.4 (required by `repl.ml`), module
`Toploop` signature includes this:
```ocaml
    type input = Stdin | File of string | String of string
    val use_silently : Format.formatter -> input -> bool
```

This broke the way `use_silently` was used, line 111 (see issue replit#118)

This change fixes this.
@cuihtlauac cuihtlauac mentioned this issue Mar 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cuihtlauac