Skip to content
This repository has been archived by the owner on May 4, 2022. It is now read-only.

Odin language support #151

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Odin language support #151

wants to merge 2 commits into from

Conversation

MoxyFoxy
Copy link

@MoxyFoxy MoxyFoxy commented Aug 3, 2020

Hello everyone!

In odin.toml I have added support for Odin, a powerful language built for the joy of programming. This was made following the requirements in the Getting Started on the Odin website.

Copy link
Contributor

@ALANVF ALANVF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odin would be nice to have, however it seems like the odin command doesn't exist after installing the language. Might be an issue in the setup section

]
packages = [
"llvm",
"clang"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, it'd be nice if you used a version of clang that other language configs are already using. At the very least, try to choose a specified version of clang and llvm.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would clang-10 and llvm-10 work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that works 👍

]
setup = [
"cd /tmp",
"git clone https://github.com/odin-lang/odin",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to delete the files once you're done using them.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, Odin requires its standard library to be relative to the itself. Therefore, at the minimum, the standard library cannot be deleted. How would you like me to handle that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the files be moved to somewhere like /usr/local/share/odin?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! That can be done

@MoxyFoxy
Copy link
Author

MoxyFoxy commented Aug 9, 2020

Hello,

I have responded to the individual conversations. As for the odin command not existing, I did not have that issue after I ran it. I even built from scratch without a cache using the command sudo docker build -t polygott-odin --build-arg LANGS=odin . --no-cache. If I did something wrong in regards to that, please let me know so I can fix it.

- Added llvm-10
- Added clang-10
- Moved from `/tmp` to `/usr/local/share`
- Made sure to clean up as much as possible
@MoxyFoxy
Copy link
Author

Hello,

Apologies as I had forgotten to comment. I made the changes you requested. Please let me know if you continue to run into any issues. I also can't replicate the odin command not existing. Was that an issue of how I built the docker? If so let me know so I can properly test that :)

@dan-stowell
Copy link
Contributor

Good afternoon @F0x1fy ! You've probably noticed by now that we've been slow to merge community PRs on polygott. We've decided to focus on giving Repl.it a stable foundation instead of adding features and updating languages. Once we and our community feel comfortable with Repl.it's overall stability, we'll give this change another look. Thank you for contributing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants