diff --git a/third_party/blink/renderer/core/dom/attribute.h b/third_party/blink/renderer/core/dom/attribute.h index f7c276d17c4516..1e20abb795e15b 100644 --- a/third_party/blink/renderer/core/dom/attribute.h +++ b/third_party/blink/renderer/core/dom/attribute.h @@ -30,9 +30,6 @@ #include "third_party/blink/renderer/core/dom/qualified_name.h" #include "third_party/blink/renderer/platform/wtf/allocator/allocator.h" -#include "base/record_replay.h" -#include "third_party/blink/renderer/core/html_names.h" - namespace blink { // This value is set fairly arbitrarily, to get above what we expect to be @@ -53,12 +50,7 @@ class Attribute { public: Attribute(const QualifiedName& name, const AtomicString& value) - : name_(name), value_(value) { - if (name == html_names::kSrcAttr) { - recordreplay::Assert("[RUN-658-1438] Attribute::Attribute %s", - value.IsNull() ? "(null)" : value.Utf8().c_str()); - } - } + : name_(name), value_(value) {} Attribute(QualifiedName&& name, AtomicString&& value) : name_(std::move(name)), value_(std::move(value)) {} @@ -76,13 +68,7 @@ class Attribute { bool Matches(const QualifiedName&) const; bool MatchesCaseInsensitive(const QualifiedName&) const; - void SetValue(const AtomicString& value) { - if (name_ == html_names::kSrcAttr) { - recordreplay::Assert("[RUN-658-1438] Attribute::SetValue %s", - value.IsNull() ? "(null)" : value.Utf8().c_str()); - } - value_ = value; - } + void SetValue(const AtomicString& value) { value_ = value; } // Note: This API is only for HTMLTreeBuilder. It is not safe to change the // name of an attribute once parseAttribute has been called as DOM diff --git a/third_party/blink/renderer/core/layout/ng/layout_ng_block_flow_mixin.cc b/third_party/blink/renderer/core/layout/ng/layout_ng_block_flow_mixin.cc index 629ccc9b70726d..a312a4f8447d49 100644 --- a/third_party/blink/renderer/core/layout/ng/layout_ng_block_flow_mixin.cc +++ b/third_party/blink/renderer/core/layout/ng/layout_ng_block_flow_mixin.cc @@ -270,6 +270,9 @@ template void LayoutNGBlockFlowMixin::UpdateNGBlockLayout() { Base::CheckIsNotDestroyed(); + recordreplay::Assert( + "[RUN-1239-2230] LayoutNGBlockFlowMixin::UpdateNGBlockLayout %d", + Base::IsOutOfFlowPositioned()); if (Base::IsOutOfFlowPositioned()) { LayoutNGMixin::UpdateOutOfFlowBlockLayout(); return; diff --git a/third_party/blink/renderer/core/layout/ng/svg/layout_ng_svg_text.cc b/third_party/blink/renderer/core/layout/ng/svg/layout_ng_svg_text.cc index b003c773a56caf..23e772f0ace3fe 100644 --- a/third_party/blink/renderer/core/layout/ng/svg/layout_ng_svg_text.cc +++ b/third_party/blink/renderer/core/layout/ng/svg/layout_ng_svg_text.cc @@ -213,7 +213,12 @@ void LayoutNGSVGText::UpdateBlockLayout(bool relayout_children) { gfx::RectF old_boundaries = ObjectBoundingBox(); + recordreplay::Assert("[RUN-1239-2230] LayoutNGSVGText::UpdateBlockLayout A %d", + GetElement()->RecordReplayId()); UpdateNGBlockLayout(); + recordreplay::Assert("[RUN-1239-2230] LayoutNGSVGText::UpdateBlockLayout B %d", + GetElement()->RecordReplayId()); + needs_update_bounding_box_ = true; gfx::RectF boundaries = ObjectBoundingBox(); diff --git a/third_party/blink/renderer/platform/geometry/layout_unit.h b/third_party/blink/renderer/platform/geometry/layout_unit.h index e0e9d6df6ef404..1145ab4662a8a9 100644 --- a/third_party/blink/renderer/platform/geometry/layout_unit.h +++ b/third_party/blink/renderer/platform/geometry/layout_unit.h @@ -246,10 +246,6 @@ class LayoutUnit { LayoutUnit AddEpsilon() const { LayoutUnit return_value; - - // https://linear.app/replay/issue/RUN-1239#comment-df307091 - recordreplay::Assert("[RUN-1239-1435] LayoutUnit::AddEpsilon %d", value_); - return_value.SetRawValue( value_ < std::numeric_limits::max() ? value_ + 1 : value_); return return_value;