Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular/incorrect package dependencies #1584

Open
SanjalKatiyar opened this issue Sep 17, 2024 · 0 comments
Open

Fix circular/incorrect package dependencies #1584

SanjalKatiyar opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@SanjalKatiyar
Copy link
Collaborator

ocs depends on core: https://github.com/red-hat-storage/odf-console/blob/master/packages/ocs/package.json#L7, despite that core have imports from ocs causing circular dependency.
ex: https://github.com/red-hat-storage/odf-console/blob/master/packages/odf/components/topology/sidebar/storage-cluster/StorageClusterObserve.tsx#L2

mco only depends upon shared: https://github.com/red-hat-storage/odf-console/blob/master/packages/mco/package.json#L6, despite that have imports from both ocs and core, hence incorrect dependency.
ex: https://github.com/red-hat-storage/odf-console/blob/master/packages/mco/components/drpolicy-list-page/drpolicy-list-page.tsx#L2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants