Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the function "generate_new_nodes_and_osd_running_nodes_ipi" wait for the new OSD node rack or zone to be ready #10534

Open
yitzhak12 opened this issue Sep 19, 2024 · 1 comment

Comments

@yitzhak12
Copy link
Contributor

In the function generate_new_nodes_and_osd_running_nodes_ipi, wait for the new OSD node rack or zone to be ready.
See the failure: https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/738/24258/1177912/1177946/log.
We should add this code

sample = TimeoutSampler(
timeout=timeout,
sleep=10,
func=is_node_rack_or_zone_exist,
node_name=new_node_name,
failure_domain=failure_domain,
)
assert sample.wait_for_func_status(
result=True
), f"Didn't find the node rack/zone after {timeout} seconds"

or similar in the function generate_new_nodes_and_osd_running_nodes_ipi here:
https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/node.py#L2909

@yitzhak12
Copy link
Contributor Author

In addition, we should add the line node_obj.reload() in the first line of the function get_node_rack_or_zone: https://github.com/red-hat-storage/ocs-ci/blob/master/ocs_ci/ocs/node.py#L2032 to reload the node object with the new data. See the related failure here: https://reportportal-ocs4.apps.ocp-c1.prod.psi.redhat.com/ui/#ocs/launches/738/25000/1212457/1212492/log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants
@yitzhak12 and others