Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No overloaded constructor for Client config #246

Closed
alko89 opened this issue Mar 11, 2022 · 2 comments
Closed

No overloaded constructor for Client config #246

alko89 opened this issue Mar 11, 2022 · 2 comments
Assignees
Labels
bug V4 v2021-02-25 Client

Comments

@alko89
Copy link

alko89 commented Mar 11, 2022

The type definition for Client constructor doesn't include the overloaded method to include client options. Because of that I'm unable to define a region as described in documentation:

image

Ignoring types does work so its obvious its a type issue:

image

Related to #177

@alko89 alko89 added the bug? label Mar 11, 2022
@douglasmiller douglasmiller added bug V4 v2021-02-25 Client and removed bug? labels Mar 11, 2022
@douglasmiller
Copy link
Contributor

Hey @alko89,

Thank you for bringing this to our attention. The region support was only recently added and the typescript definitions were missed. We will have to update our code generator to fix this.

I'll leave this issue open until the fix has been merged and deployed.

@alko89
Copy link
Author

alko89 commented Mar 12, 2022

Noticed the PR, tested working. Thanks for the quick fix!

On an unrelated note some typings do leave a lot to be desired. I noticed a lot of parameters have Object type instead of an actual type.

@alko89 alko89 closed this as completed Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V4 v2021-02-25 Client
Projects
None yet
Development

No branches or pull requests

2 participants