Dont trigger for non-optional type casting, or for optional types #5805
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mildm8nnered
force-pushed
the
mildm8nnered-prefer-type-checking-fix
branch
from
2020e54
to
4999b47
Compare
mildm8nnered
force-pushed
the
mildm8nnered-prefer-type-checking-fix
branch
from
4999b47
to
efa6b93
Compare
Naveen-C-Ramachandrappa
approved these changes
Oct 3, 2024
mildm8nnered
force-pushed
the
mildm8nnered-prefer-type-checking-fix
branch
from
efa6b93
to
1b33458
Compare
2 tasks
SimplyDanny
requested changes
Oct 7, 2024
| @@ -24,6 +24,9 @@ struct PreferTypeCheckingRule: Rule { | |||
| foo.run() | |||
| } | |||
| """), | |||
| Example("bar as Foo? != nil"), | |||
| Example("bar as Foo? != nil"), | |||
There was a problem hiding this comment.
This line is a duplicate.
| @@ -24,6 +24,9 @@ struct PreferTypeCheckingRule: Rule { | |||
| foo.run() | |||
| } | |||
| """), | |||
| Example("bar as Foo? != nil"), | |||
| Example("bar as Foo? != nil"), | |||
| Example("bar as? Foo? != nil"), | |||
There was a problem hiding this comment.
This could actually be written as bar is Foo, couldn't it?
There was a problem hiding this comment.
I think that depends on whether bar is nil or not:
var bar: String? = nil
print(bar as? String? != nil)
print(bar is String?)
print(bar is String)
prints
true
true
false
but
var bar: String? = "foo"
print(bar as? String? != nil)
print(bar is String?)
print(bar is String)
prints
true
true
true
| var asExprWithOptionalTypeChecking: AsExprSyntax? { | ||
| if let asExpr = leftOperand.as(AsExprSyntax.self), | ||
| asExpr.questionOrExclamationMark?.tokenKind == .postfixQuestionMark, | ||
| asExpr.type.is(OptionalTypeSyntax.self) == false, |
There was a problem hiding this comment.
Suggested change
| asExpr.type.is(OptionalTypeSyntax.self) == false, | |
| !asExpr.type.is(OptionalTypeSyntax.self), |
There was a problem hiding this comment.
This rule doesn't consider that != is commutative. So cases like nil != bar as? Int are not found.
There was a problem hiding this comment.
That is true - I'm not sure how common that is, but it should be pretty easy to cover
mildm8nnered
force-pushed
the
mildm8nnered-prefer-type-checking-fix
branch
from
63e1ee5
to
bddd8c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5802
We no longer trigger unless the type casting is optional (
as?), or if the type is optional.Essentially, in either case, the correction would change the resulting
trueorfalsevalue. See #5802 for details.We also now check for
nil != foo as? Barcases