Added lenient command line option
#5801
Open
+35
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
mildm8nnered
force-pushed
the
mildm8nnered-add-lenient-option-to-config-file
branch
from
4c5f7d0
to
fc3c378
Compare
mildm8nnered
force-pushed
the
mildm8nnered-add-lenient-option-to-config-file
branch
from
fc3c378
to
5a9b47c
Compare
mildm8nnered
force-pushed
the
mildm8nnered-add-lenient-option-to-config-file
branch
from
5a9b47c
to
a399c0b
Compare
2 tasks
|
The options turn more and more complex. It'd be really useful to have the combinations tested. |
mildm8nnered
force-pushed
the
mildm8nnered-add-lenient-option-to-config-file
branch
from
a399c0b
to
f06b9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5779
So I basically just copied #5226 (which I wrote).
If you have
strictandlenientas true in the config file, afatalErrorwill be thrown, but either can be overridden by the--strictor--lenientcommand line options, and they will also override the opposite setting in the config file.For example, if you have
lenient: truein your config file, but you specify--stricton the command line, you will get thestrictbehaviour, and your config file setting will be ignored.I tested this manually - it was hard to do a unit test, because we
fatalErrorinstead of throwing an error right now.As before,
--strictand--lenienton the command line will also fatal error.