This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Fixed generators to work from a mountable Rails engine #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR. How can I reproduce the problem you are facing with the current implementation? Does this change the behavior of the most comment use case? Do we have to migrate existing installations? |
|
@pencil you can test this by creating a mountable Rails engine, and mounting CASino. Then (from the rails engine root) try running the generator |
|
Does this change anything for existing installations? Are the commands still the same? |
joelvh
force-pushed
the
master
branch
2 times, most recently
from
882c5d8
to
922ee7d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Rails engine "namespace" to asset paths when installing CASino. Added migrations generator to copy migrations because the built-in
rake railties:install:migrationsdoes not work when running the command on a Rails engine. It's a simple fix to copy the files.Given, we may have a special case where we're mounting CASino in another mountable Rails engine.