Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move public/csvlens back under the apps showcase folder #347

Open
joshka opened this issue Jan 5, 2024 · 2 comments
Open

Move public/csvlens back under the apps showcase folder #347

joshka opened this issue Jan 5, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@joshka
Copy link
Member

joshka commented Jan 5, 2024

I moved the csvlens demo gif into public because it triggered the bug in astro that doesn't handle large images. This was fixed in the latest release in PR withastro/astro#9546

Need to investigate turning on the setting, and move it back inside the app showcase folder.
@joshka joshka added the good first issue Good for newcomers label Jan 5, 2024
@mccartney
Copy link
Contributor

I moved the csvlens demo gif into public

I guess this was done in #329.

@kdheepak
Copy link
Contributor

kdheepak commented Feb 25, 2024 •
edited
Loading

This PR allows our astro configuration to handle large images: #466

So no change is needed in our astro configuration, just the csvlens demo needs to be moved out of public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshka @mccartney @kdheepak