archived messages are posted from user who installed destalinator

[ahalasz]

Hi,

I installed destalinator using the docker image and I noticed that, when a channel is archived, the corresponding message does not come from destalinator but from my user.
The warning messages come, as desired, from destalinator and the messages for the new channels created come from slackbot.

I tried to make the archiving messages come from destalinator as well by adding this bot to my Slack app and using the bot's API TOKEN. However, when I do so, running warner.py will give the following error:

# ./warner.py 2017-12-13 09:59:34,277 [DEBUG]: activated is TRUE 2017-12-13 09:59:34,285 [INFO]: Starting new HTTPS connection (1): slacktest.slack.com 2017-12-13 09:59:34,418 [DEBUG]: "GET /api/users.list?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9 HTTP/1.1" 200 1466 2017-12-13 09:59:34,420 [DEBUG]: All restricted user names: 2017-12-13 09:59:34,488 [DEBUG]: "GET /api/channels.list?exclude_archived=1&token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9 HTTP/1.1" 200 711 2017-12-13 09:59:34,490 [DEBUG]: activated is TRUE 2017-12-13 09:59:34,492 [INFO]: Warning 2017-12-13 09:59:34,492 [INFO]: *ACTION: Warning all channels stale for more than 30 days* 2017-12-13 09:59:34,492 [DEBUG]: Not warning #destalinator-log because it's in ignore_channels 2017-12-13 09:59:34,562 [DEBUG]: "GET /api/channels.info?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1 HTTP/1.1" 200 335 2017-12-13 09:59:34,637 [DEBUG]: "GET /api/channels.info?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1 HTTP/1.1" 200 335 2017-12-13 09:59:34,638 [DEBUG]: Current members in general are set([u'U5FFN9XPA', u'U1EA01HH9']) 2017-12-13 09:59:34,696 [DEBUG]: "GET /api/channels.history?oldest=1510567174&token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1&latest=1513159174 HTTP/1.1" 200 99 Traceback (most recent call last): File "./warner.py", line 18, in <module> Warner().warn(force_warn=force_warn) File "./warner.py", line 11, in warn self.ds.warn_all(self.config.warn_threshold, force_warn) File "/destalinator/destalinator.py", line 234, in warn_all if self.stale(channel, days): File "/destalinator/destalinator.py", line 121, in stale messages = self.get_messages(channel_name, days) File "/destalinator/destalinator.py", line 83, in get_messages messages = self.slacker.get_messages_in_time_range(oldest, cid) File "/destalinator/slacker.py", line 91, in get_messages_in_time_range messages += payload['messages'] KeyError: 'messages'

[kmarekspartz]

Yes, this was due to bot users not having permissions to archive channels. This also is why there are two tokens as part of the setup. It’s possible that newer API versions would let us merge these functions to use a single non-user token. – Kyle Marek-Spartz

…

On Dec 13, 2017, at 04:01, ahalasz ***@***.***> wrote: Hi, I installed destalinator using the docker image and I noticed that, when a channel is archived, the corresponding message does not come from destalinator but from my user. The warning messages come, as desired, from destalinator and the messages for the new channels created come from slackbot. I tried to make the archiving messages come from destalinator as well by adding this bot to my Slack app and using the bot's API TOKEN. However, when I do so, running warner.py will give the following error: # ./warner.py 2017-12-13 09:59:34,277 [DEBUG]: activated is TRUE 2017-12-13 09:59:34,285 [INFO]: Starting new HTTPS connection (1): slacktest.slack.com 2017-12-13 09:59:34,418 [DEBUG]: "GET /api/users.list?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9 HTTP/1.1" 200 1466 2017-12-13 09:59:34,420 [DEBUG]: All restricted user names: 2017-12-13 09:59:34,488 [DEBUG]: "GET /api/channels.list?exclude_archived=1&token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9 HTTP/1.1" 200 711 2017-12-13 09:59:34,490 [DEBUG]: activated is TRUE 2017-12-13 09:59:34,492 [INFO]: Warning 2017-12-13 09:59:34,492 [INFO]: *ACTION: Warning all channels stale for more than 30 days* 2017-12-13 09:59:34,492 [DEBUG]: Not warning #destalinator-log because it's in ignore_channels 2017-12-13 09:59:34,562 [DEBUG]: "GET /api/channels.info?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1 HTTP/1.1" 200 335 2017-12-13 09:59:34,637 [DEBUG]: "GET /api/channels.info?token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1 HTTP/1.1" 200 335 2017-12-13 09:59:34,638 [DEBUG]: Current members in general are set([u'U5FFN9XPA', u'U1EA01HH9']) 2017-12-13 09:59:34,696 [DEBUG]: "GET /api/channels.history?oldest=1510567174&token=xoxb-285445889489-DnuE3IcKoJ0Y7qaANRkNtak9&channel=C1EA01JR1&latest=1513159174 HTTP/1.1" 200 99 Traceback (most recent call last): File "./warner.py", line 18, in <module> Warner().warn(force_warn=force_warn) File "./warner.py", line 11, in warn self.ds.warn_all(self.config.warn_threshold, force_warn) File "/destalinator/destalinator.py", line 234, in warn_all if self.stale(channel, days): File "/destalinator/destalinator.py", line 121, in stale messages = self.get_messages(channel_name, days) File "/destalinator/destalinator.py", line 83, in get_messages messages = self.slacker.get_messages_in_time_range(oldest, cid) File "/destalinator/slacker.py", line 91, in get_messages_in_time_range messages += payload['messages'] KeyError: 'messages' — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[ahalasz]

Thanks, so if I understand correctly I cannot do anything about this for the moment right?

Andrei

[kmarekspartz]

Not with the current code, no, but looking into the Slack APIs and the code may lead to a way to fix this.