Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel warning and closure messages should be templated #163

Open
ahalasz opened this issue Dec 11, 2017 · 2 comments
Open

Channel warning and closure messages should be templated #163

ahalasz opened this issue Dec 11, 2017 · 2 comments

Comments

@ahalasz
Copy link

ahalasz commented Dec 11, 2017

Hi,

I changed the archive_threshold to 37 in the configuration.yaml. Afterwards I rebuilt the destalinator Docker image, run it and entered the container. In the container I run the warner.py, which send a message to the concerned channels in the Slack.

The message in #general was:

Hey, heads up -- the following channels are stale and will be archived if no one participates in them over the next 30 days

The message in the concerned channels ended with

.If we don't hear from anyone in the next 30 days, this channel will be archived.

I was expecting to see 7 days instead of 30 days in those messages.

Extract of the con figuration.yaml:

# Days of silence before we warn a channel it's going to be archived
warn_threshold: 30

# Days of silence before we auto-archive a channels
archive_threshold: 37
@kmarekspartz
Copy link
Contributor

These are currently hardcoded in:

https://github.com/randsleadershipslack/destalinator/blob/master/warning.txt
and
https://github.com/randsleadershipslack/destalinator/blob/master/closure.txt

Updating those to be templated is reasonable, though we could hard code the warn and archive thresholds everywhere, as they are decent defaults.

@ax42
Copy link

ax42 commented Dec 11, 2017

Recommend they are either hard-coded everywhere (i.e. not a parameter at all) or templated. Parameters are clearly more user-friendly. For our company slack we would prefer to have a shorted archive threshold (warn, and then archive quickly, not give another 30 days).

@h3h h3h added enhancement and removed bug labels Mar 13, 2021
@h3h h3h changed the title archive_threshold is always considered as 30 days even if changed Channel warning and closure messages should be templated Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants